Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-analyzer proc-macro server project #24

Merged
merged 2 commits into from
Feb 22, 2025

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Feb 22, 2025

No description provided.

Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good already! Let me know once you un-draft it when you want to merge it.

@Veykril
Copy link
Member Author

Veykril commented Feb 22, 2025

I want to sketch up a rough plan / roadmap first. Will either do so today or tomorrow

@Kobzol
Copy link
Collaborator

Kobzol commented Feb 22, 2025

Ok! I think that what you have in "Expected result" is in fact a roadmap (although it would be great if you can further extend it, of course!), and the expected result should just be something like "There exists a proc-macro server that is more efficient and supports more use-cases. Ideally, it should be integrated within RA/RustRover.", or something like that.

@Veykril Veykril force-pushed the veykril/push-qqsqwrrumtyt branch from e5de328 to 0d2a1ce Compare February 22, 2025 16:10
@Veykril Veykril marked this pull request as ready for review February 22, 2025 16:11
@Veykril
Copy link
Member Author

Veykril commented Feb 22, 2025

Okay I replaced the expected results part and created a tracking issue in the r-a repo that outlines more finer details rust-lang/rust-analyzer#19205

Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this sounds like a great fit for GSoC indeed! Left one nit.

@Veykril Veykril force-pushed the veykril/push-qqsqwrrumtyt branch from 0d2a1ce to 2c582ef Compare February 22, 2025 16:37
@Kobzol
Copy link
Collaborator

Kobzol commented Feb 22, 2025

Pushed a link anchor fix, I missed it previously. Thank you!

@Kobzol Kobzol merged commit 5640325 into rust-lang:main Feb 22, 2025
@Veykril Veykril deleted the veykril/push-qqsqwrrumtyt branch February 22, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants